Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Seti to support Notebook icons #143313

Merged
merged 3 commits into from Feb 22, 2022
Merged

Update Seti to support Notebook icons #143313

merged 3 commits into from Feb 22, 2022

Conversation

rebornix
Copy link
Member

Rerun update-icon-theme.js to get the latest Seti icons. Current one doesn't pick the notebook icon for ipynb (it shows as JSON) but once it's updated, it works as expected.

@rebornix
Copy link
Member Author

@aeschli can you please help take a look at this PR?

@aeschli
Copy link
Contributor

aeschli commented Feb 22, 2022

You need to first run npm run prepublishOnly in the seti repo to update the font and font character table (seti.less).
The run npm run update in the extensions/theme-seti directory.

I pushed the update.

@aeschli aeschli merged commit 67f1fa6 into main Feb 22, 2022
@aeschli aeschli deleted the rebornix/updateSeti branch February 22, 2022 20:51
@rebornix
Copy link
Member Author

Thanks @aeschli !

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants