Add codelens to ipynb json file to open in notebook editor #143422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Feb 19, 2022
| @@ -55,6 +65,14 @@ export function activate(context: vscode.ExtensionContext) { | |||
| await vscode.window.showNotebookDocument(doc); | |||
| })); | |||
|
|
|||
| context.subscriptions.push(vscode.commands.registerCommand('ipynb.openIpynbInNotebookEditor', async (uri: vscode.Uri) => { | |||
| if (vscode.window.activeTextEditor?.document.uri.toString() === uri.toString()) { | |||
| await vscode.commands.executeCommand('workbench.action.closeActiveEditor'); | |||
There was a problem hiding this comment.
I thought there would be a generic "reopen in editor" command, maybe not
There was a problem hiding this comment.
We can extends workbench.action.reopenWithEditor to support taking arguments later.
roblourens
reviewed
Feb 19, 2022
roblourens
reviewed
Feb 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ipynb files are corrupted, users can open them in Text Editor (see #142875 (comment)) but once the file is fixed, there isn't a clear way to reopen it in Notebook Editor. This is an exploration of adding a codelens to the ipynb json file to make it easy and discoverable.