Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer - add "Open Recent" to web serverless empty explorer #143464

Merged
merged 1 commit into from Feb 20, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Feb 19, 2022

This makes:

  • the existing "Empty Explorer" welcome contributions easier to read by documenting the context keys and rules better [1]
  • add a "Open Recent" for vscode.dev [2]

[1] maybe this is a chance to review some of the rules and see if they still apply. The reasoning behind some is really not entirely clear to me.

[2] the condition used here is WorkbenchStateContext.isEqualTo('workspace') and OpenFolderWorkspaceSupportContext.toNegated() which is used in other places to identify vscode.dev (we automatically put the user into an empty workspace with tmp scheme to enable opening local folders without window reload, but we never support opening folders or workspaces otherwise). Compare with a similar commit I pushed to have "Open Folder" map to "Add Folder to Workspace": 12f9c5f

I felt that showing "Open Recent" for every explorer might be a bit too much because the button is quite heavy when you stack 2 of them:

image

Compared to the current welcome screen (which btw wrongly talks about "Adding Folder" to the workspace):

image

//cc @isidorn

@bpasero bpasero added this to the February 2022 milestone Feb 19, 2022
@bpasero bpasero self-assigned this Feb 19, 2022
@bpasero bpasero merged commit 68fa627 into main Feb 20, 2022
@bpasero bpasero deleted the ben/web-welcome branch February 20, 2022 07:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants