explorer - add "Open Recent" to web serverless empty explorer #143464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes:
[1] maybe this is a chance to review some of the rules and see if they still apply. The reasoning behind some is really not entirely clear to me.
[2] the condition used here is
WorkbenchStateContext.isEqualTo('workspace')
andOpenFolderWorkspaceSupportContext.toNegated()
which is used in other places to identify vscode.dev (we automatically put the user into an empty workspace withtmp
scheme to enable opening local folders without window reload, but we never support opening folders or workspaces otherwise). Compare with a similar commit I pushed to have "Open Folder" map to "Add Folder to Workspace": 12f9c5fI felt that showing "Open Recent" for every explorer might be a bit too much because the button is quite heavy when you stack 2 of them:
Compared to the current welcome screen (which btw wrongly talks about "Adding Folder" to the workspace):
//cc @isidorn