Test: electron 17 update

[deepak1556]

Refs: #143223

• macOS @sandy081
• linux @brettcannon
• windows @bamurtaugh

Complexity: 3

Create Issue

---

We plan to promote Electron 17 in the March 2022 milestone for insiders and stable. The following tests cover some of the common UI bits that don't have smoke tests, but feel free to self-host on the nightly builds for rest of the iteration. You can download the nightly explorations builds from here for testing.

---

Testing:

• macOS:

  • Enable Native Tabs (via settings: window.nativeTabs: true)
    • Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
    • Launch application
    • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
    • Verify new window is launched as a new tab in the active instance of the application
  • window is focused when starting from command line
    • open the code exploration application from finder or dock
    • open external terminal
    • run code-exploration
    • make sure the new window is put to foreground

• windows:

  • touch device, verify onscreen keyboard doesn't pop up when clicking inside vscode while external keyboard is attached
  • verify maximize and restore operations work as expected when task bar is auto-hidden for custom titlebar
  • Verify titlebar is not clipped off when exit fullscreen
    • Maximize VS Code window
    • Press F11 or Ctrl+K Z twice to enter/exit full screen.
    • Verify titlebar is not cropped
  • Verify there is no rendering lag with custom titlebar

• linux:

  • Verify application launches successfully with the following install flavors on any of the minimum supported distro version described in https://code.visualstudio.com/docs/supporting/requirements#_platforms
    • Snap
    • Deb
    • RPM

• All OS:

  • Check out the electron-17.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using Developer: Toggle Developer Tools

[bamurtaugh]

Check out the electron-16.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using Developer: Toggle Developer Tools

Should this be "Check out the electron-17.x.y branch"?

[deepak1556]

Yup it should be electron-17.x.y, fixed the template. Thanks!

[brettcannon]

@deepak1556 I was able to install via .deb under WSL and launch w/o issue. Unfortunately building from a checkout is failing due to native-keymap not building when running yarn. Is the .deb test good enough or do you need me to find someone to do a proper Linux build test?

[deepak1556]

@brettcannon can you please find someone to verify OSS self-hosting steps, it would be good to cover that as part of this testing. Thanks!

[brettcannon]

Connor was nice enough to verify things for me!