Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readOnly lazy attributes are not respected #143790

Closed
connor4312 opened this issue Feb 23, 2022 · 5 comments
Closed

readOnly lazy attributes are not respected #143790

connor4312 opened this issue Feb 23, 2022 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

Testing #143572

  1. Create a variable with only a getter, so that it contains readOnly in its presentationHint.attributes
  2. Notice double clicking still allows setting it
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 23, 2022
@weinand
Copy link
Contributor

weinand commented Feb 23, 2022

Most likely this is not a specific problem of "lazy" variables...

@connor4312
Copy link
Member Author

Looks like that's correct. I fixed this a short while ago in 989bb81 but it seems like it regressed.

@connor4312 connor4312 self-assigned this Feb 23, 2022
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2022
@roblourens
Copy link
Member

It seems like js-debug might not be sending a presentationHint on the resolved lazy property. I see 'readonly' and 'lazy' there before it's resolved but not after.

@connor4312 connor4312 added this to the March 2022 milestone Feb 28, 2022
@weinand weinand added the verified Verification succeeded label Mar 24, 2022
@weinand
Copy link
Contributor

weinand commented Mar 24, 2022

Yes, a "lazy" without a setter does not react on double click, so its value cannot be set.

However, if a setter is added, it still does not react on double click.
@connor @roblourens is this a problem of js-debug or VS Code?

@connor4312
Copy link
Member Author

yep, will fix in js-debug

@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants