Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jackson/lang-detect-min-text #144105

Merged
merged 2 commits into from Feb 28, 2022
Merged

Jackson/lang-detect-min-text #144105

merged 2 commits into from Feb 28, 2022

Conversation

JacksonKearl
Copy link
Contributor

@JacksonKearl JacksonKearl commented Feb 28, 2022 •
edited

Fixes #143930. Basically just don't start guessing until we have a line or at least 20 chars.

Ideal solution would be for the model to better report confidence but for the candidate this is sufficient IMO.

@JacksonKearl JacksonKearl self-assigned this Feb 28, 2022
TylerLeonhardt
TylerLeonhardt approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonKearl JacksonKearl merged commit 5db76fd into release/1.65 Feb 28, 2022
@JacksonKearl JacksonKearl deleted the jackson/lang-detect-min-text branch February 28, 2022 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@JacksonKearl JacksonKearl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JacksonKearl @TylerLeonhardt