Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The available profiles from terminalProfileService always use the default args for zsh, [-l], even when that's changed. #144197

Closed
meganrogge opened this issue Mar 1, 2022 · 1 comment
Closed

The available profiles from terminalProfileService always use the default args for zsh, [-l], even when that's changed. #144197

meganrogge opened this issue Mar 1, 2022 · 1 comment
Assignees
@Tyriar @meganrogge

Comments

@meganrogge
Copy link
Contributor

The available profiles from terminalProfileService always use the default args for zsh, [-l], even when that's changed.
Screen Shot 2022-03-01 at 12 50 24 PM
logged that here

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Line 928 in 07aa73b


when I have

 "zsh": {
      "path": "zsh",
    },

or

 "zsh": {
      "path": "zsh",
      "args": []
    },

Originally posted by @meganrogge in #144196 (comment)
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Mar 1, 2022
@meganrogge meganrogge added this to the February 2022 milestone Mar 1, 2022
@meganrogge meganrogge removed bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Mar 1, 2022
@meganrogge
Copy link
Contributor Author

closing because setting them to [] fixes this

@Tyriar Tyriar removed this from the February 2022 milestone Mar 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge