Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align editor find widget with the notebook find widget #144851

Open
rebornix opened this issue Mar 10, 2022 · 0 comments
Open

Align editor find widget with the notebook find widget #144851

rebornix opened this issue Mar 10, 2022 · 0 comments
Assignees
@rebornix
Labels
editor-find Editor find operations polish Cleanup and polish issue ux User experience issues

Comments

@rebornix
Copy link
Member

To allow more filters/scopes for the find widget in monaco editor (for example, supporting search in strings/comments), we may want to align the ux with the notebook find widget by moving Find in Selection icon into the Find Input

image
@rebornix rebornix self-assigned this Mar 10, 2022
@rebornix rebornix added editor-find Editor find operations polish Cleanup and polish issue ux User experience issues labels Mar 10, 2022
@kieferrm kieferrm mentioned this issue Mar 14, 2022
Closed
87 tasks
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
99 tasks
@rebornix rebornix mentioned this issue Jul 18, 2022
Merged
4 tasks
@kieferrm kieferrm mentioned this issue Aug 7, 2022
Closed
@kieferrm kieferrm mentioned this issue Sep 4, 2022
Closed
@kieferrm kieferrm mentioned this issue Oct 8, 2022
Closed
77 tasks
@amunger amunger mentioned this issue Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

Labels
editor-find Editor find operations polish Cleanup and polish issue ux User experience issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rebornix