notebook comment support #145090
Merged
notebook comment support #145090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexr00 FYI, to support comments in notebook editor, I decoupled the comment widget from the |
alexr00
reviewed
Mar 18, 2022
| @@ -212,8 +218,8 @@ export class MainThreadCommentController { | |||
| return this._features.options; | |||
| } | |||
|
|
|||
| private readonly _threads: Map<number, MainThreadCommentThread> = new Map<number, MainThreadCommentThread>(); | |||
| public activeCommentThread?: MainThreadCommentThread; | |||
| private readonly _threads: Map<number, MainThreadCommentThread<IRange | ICellRange>> = new Map<number, MainThreadCommentThread<IRange | ICellRange>>(); | |||
There was a problem hiding this comment.
Should MainThreadCommentController also be templated so that IRange | ICellRange can be a T?
| if (matchedZones.length) { | ||
| let matchedZone = matchedZones[0]; | ||
| matchedZone.update(thread); | ||
| if (thread.isDocumentCommentThread()) { |
There was a problem hiding this comment.
We now need to have these checks in various places. Would it make more sense to have a separate notebook comments service?
There was a problem hiding this comment.
or, at the very least, separate onDidUpdateCommentThreads events for documents and notebooks?
There was a problem hiding this comment.
💯 for filtering through onDidUpdateCommentThreads.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #144850. The changes included:
CommentThreadWidgetfromZoneWidgetand make it reuseable for Notebook.CommentThreadtoCommentThread<T>whereTis eitherIRangeorICellRange.CellCommentscell part in notebookOriginally I thought we should at least introduce a new API to allow contributing comments to notebook cells but at the end I took a shortcut: extensions contribute comments to notebook cells and we render comments in notebook cells instead of inside the cell editor.