Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up TS 4.7 for building VS Code #145273

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Pick up TS 4.7 for building VS Code #145273

merged 2 commits into from
Mar 17, 2022

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Mar 16, 2022

Implements the newly required methods from microsoft/TypeScript#48276

@mjbvz mjbvz added this to the March 2022 milestone Mar 16, 2022
@mjbvz mjbvz requested a review from alexdima March 16, 2022 22:43
@mjbvz mjbvz self-assigned this Mar 16, 2022
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 16, 2022

@alexdima I'm kicking off a build to test these changes. Please take a quick look at the additions and let me know if you have any concerns about them

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great! Thanks for adopting the new TS service APIs!

@mjbvz mjbvz merged commit bc9de9e into main Mar 17, 2022
@mjbvz mjbvz deleted the dev/mjbvz/ts-47-0301622 branch March 17, 2022 18:10
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 17, 2022

Just sanity tested the build and it seems good. Merging but will keep an eye out for any issues

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants