Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The terminal process failed to launch when I reopen VSCode after using Command+Q to quit VSCode #145364

Closed
SilvRunrun opened this issue Mar 18, 2022 · 1 comment · Fixed by #157377
Closed

The terminal process failed to launch when I reopen VSCode after using Command+Q to quit VSCode #145364

SilvRunrun opened this issue Mar 18, 2022 · 1 comment · Fixed by #157377
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone
August 2022

Comments

@SilvRunrun
Copy link

SilvRunrun commented Mar 18, 2022 •
edited

  1. create a directory at path: /Users/ma/本地/demo_project.(contains Chinese component)
  2. open the directory from VSCode top menu: File - Open...
  3. open a new terminal from top menu: Terminal - New Terminal. and terminal window automatically goes to path (demo_project).
  4. use Command + Q shortcut to quit VSCode completely.
  5. reopen VSCode from mac dock icon. and VSCode shows error: The terminal process failed to launch: Starting directory (cwd) "/Users/ma/\xe6\x9c\xac\xe5\x9c\xb0/demo_project" does not exist.
  6. when the path in step1 does not contain Chinese(like /Users/ma/local/demo_project.), no error shows. the error only shows when the path contains Chinese.

Extra VSCode information：
Version: 1.65.2 (Universal)
Commit: c722ca6
Date: 2022-03-10T14:33:49.188Z (1 wk ago)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.4.0
@SilvRunrun SilvRunrun reopened this Mar 18, 2022
@meganrogge meganrogge added confirmation-pending terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Mar 21, 2022
@pingren pingren mentioned this issue Aug 6, 2022
Merged
@Tyriar Tyriar added this to the August 2022 milestone Aug 8, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed confirmation-pending labels Aug 8, 2022
@Tyriar
Copy link
Member

Tyriar commented Aug 8, 2022

To verifier: When testing make sure shell integration is off

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 8, 2022
@DonJayamanne DonJayamanne added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Add env for terminalProcess getCwd Unicode path on macOS pingren/vscode
5 participants
@DonJayamanne @Tyriar @SilvRunrun @meganrogge @VSCodeTriageBot