Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface executing command in Terminal: Run Recent Command #145412

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Surface executing command in Terminal: Run Recent Command #145412

merged 3 commits into from
Mar 18, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 18, 2022

Fixes #143704

Changes:

  • Expose executingCommand/cwd on command detection capability and use in runRecent
  • Windows executed command marker is evaluated earlier.
  • Note that despite the above item, this does not work on Windows currently because we cannot reliably get the command line until it is finished.

@Tyriar Tyriar added this to the March 2022 milestone Mar 18, 2022
@Tyriar Tyriar requested a review from meganrogge March 18, 2022 17:12
@Tyriar Tyriar self-assigned this Mar 18, 2022
@Tyriar Tyriar merged commit e659fcb into main Mar 18, 2022
@Tyriar Tyriar deleted the tyriar/143704 branch March 18, 2022 19:05
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2022
Development

Successfully merging this pull request may close these issues.

Terminal: command should be added to recent list on execution not on completion
2 participants
@Tyriar @meganrogge