Expose checkbox in extension dialog API

[sandy081]

Testing #145525

Don't show again should be a checkbox instead of button. It is not an action. Sync or Do not Sync are actions. I would choose one action and check Don't show again option.

[chris-miner]

This would be a nice bit of UI for any of the "don't show again" buttons. For example, the file extensions pop-up that offers to help find marketplace extensions:

It has an easily clickable button for "Don't Show Again". Unfortunately, (based on a search that lead me here) there doesn't seem to be a way to undo that preference if you accidentally click the button rather than the other one. "Don't Show Again" is a setting (workspace or user) so I agree with @sandy081 that it probably shouldn't be fronted by a button, which implies something else. And in any case, one ought to be able to easily change a setting through the UI.

[joyceerhl]

@sandy081 Do extensions have the ability to contribute checkboxes in modal dialogs?

[sandy081]

I do not know. @bpasero may be the right person to reply

[bpasero]

I think that is not possible today because the API is pretty much shared between notifications and dialogs.

[bpasero]

I wonder if we need to start thinking about an independent dialog API extensions can use with all the supports we have in core. Especially when we decide to give the user more control over disabling notifications, we will see extensions use modal dialogs more and I think we have to be prepared for that and avoid dialogs that are not following our patterns.

//cc @sbatten @jrieken

[sbatten]

Today we have the stable:

vscode/src/vscode-dts/vscode.d.ts

Lines 1964 to 1976 in 115327e

	export interface MessageOptions {
	/**
	* Indicates that this message should be modal.
	*/
	modal?: boolean;
	/**
	* Human-readable detail message that is rendered less prominent. _Note_ that detail
	* is only shown for {@link MessageOptions.modal modal} messages.
	*/
	detail?: string;
	}

and proposed:

vscode/src/vscode-dts/vscode.proposed.resolvers.d.ts

Lines 10 to 15 in ab1a31a

	export interface MessageOptions {
	/**
	* Do not render a native message box.
	*/
	useCustom?: boolean;
	}

My first suggestion is that we update the modal property from a boolean to a ModalOptions bag which can take checkbox information and possibly the custom property.

[sbatten]

Oh I see detail is for modals only as well. That's fairly suspicious that all of the MessageOptions properties apply to dialogs only