Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestItem tags array is empty when passed to command triggered by additional menu item #145777

Closed
KaravolisL opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone

Comments

@KaravolisL
Copy link

Does this issue occur when all extensions are disabled?: Yes

Version: 1.65.2 (user setup)
Commit: c722ca6
Date: 2022-03-10T14:33:55.248Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

Steps to Reproduce:
I have an extension that is creating a TestController object and creating a few TestItems. I'm adding TestTags to each items' tags array in order to categorize them. I have an additional contributed menu item (inline) that triggers a command for the selected TestItem. I'd expect that the selected test item gets passed to the command with its TestTags, but it shows as empty (see below).

image

I've uploaded a simple extension that demonstrates the problem here: https://github.com/KaravolisL/simple-test-extension
Please let me know if any more information is needed. Thanks!

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Mar 22, 2022
@connor4312 connor4312 added this to the April 2022 milestone Mar 29, 2022
@KaravolisL
Copy link
Author

@connor4312 Thanks for working on this so quickly! I tried to verify this in insiders, but now the command is not even getting executed when the test item is clicked. I'm using the same sample extension in the original report. Here is my setup information:

Version: 1.67.0-insider (user setup)
Commit: 909602c
Date: 2022-03-31T11:00:49.798Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Windows_NT x64 10.0.19043

Should I submit a new issue for this?

@connor4312
Copy link
Member

Thanks for verifying! Please try this once more tomorrow, I put in a fix earlier today for that, which was a result of some other refactors 804dc2f

@KaravolisL
Copy link
Author

Looks like it's fixed:

Version: 1.67.0-insider (user setup)
Commit: 8b7086a
Date: 2022-04-01T05:16:02.350Z
Electron: 17.3.0
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.19043

image

@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@connor4312 @KaravolisL @JacksonKearl and others