Check maxTokenizationLineLength in monarchLexer #145979
Conversation
|
|
|
Sorry for the delay, I've finally been signed off by my employer @alexdima |
Lazyuki
force-pushed
the
fix-maxTokenizationLineLength-for-monaco
branch
from
9b97b2f
to
e85893c
Compare
|
Could I get reviews? This bug is freezing up the UIs and there's no workaround other than fixing it in the source. |
|
@alexdima could you run the CI again? I rebased on the main branch since there was a conflict. |
Lazyuki
force-pushed
the
fix-maxTokenizationLineLength-for-monaco
branch
2 times, most recently
from
84c9752
to
856618f
Compare
|
Hi @hediet you seem to be assigned to the original bug report issue. Could you run the CI? This bug is making the UI unresponsive for 5+ seconds sometimes. |
|
It seems like the |
alexdima
force-pushed
the
fix-maxTokenizationLineLength-for-monaco
branch
from
856618f
to
f260b7f
Compare
Lazyuki
force-pushed
the
fix-maxTokenizationLineLength-for-monaco
branch
from
f260b7f
to
28f1195
Compare
|
Looks like the recently added |
Lazyuki
force-pushed
the
fix-maxTokenizationLineLength-for-monaco
branch
from
28f1195
to
d1fcde7
Compare
|
@alexdima hello could you run the CI? |
| this._maxTokenizationLineLength = this._configurationService.getValue<number>('editor.maxTokenizationLineLength', { | ||
| overrideIdentifier: this._languageId | ||
| }); | ||
| this._configurationService.onDidChangeConfiguration(e => { |
There was a problem hiding this comment.
Should this listener be disposed at some point?
There was a problem hiding this comment.
Good point! I'll do a follow-up PR.
|
Thank you! |
This PR fixes microsoft/monaco-editor#3025
The issue is described in the issue linked above, but basically when
monaco-editorwas parsing and tokenizing lines, it was usingmonarchtokenizer instead ofTextMatetokenizer which was already checking themaxTokenizationLineLengthoption. So I added themaxTokenizationLineLengthcheck inmonarchtokenizer as well.