Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of CSS Preprocessor Comments at Start of File in Emmet Extension #146121

Merged
merged 4 commits into from Apr 4, 2022

Conversation

tharbakim
Copy link
Contributor

This PR fixes #142109

Tyler McEnaney and others added 2 commits March 26, 2022 16:44
Adds a clause for detecting `//` as a comment marker when working backwards through a file, preventing the parser from getting stuck when the comment starts at 1:1
tharbakim and others added 2 commits April 1, 2022 14:23
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good check, thanks!

@rzhao271 rzhao271 added this to the April 2022 milestone Apr 1, 2022
@rzhao271 rzhao271 merged commit fb5e446 into microsoft:main Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[emmet] VSCode becomes unresponsive when editing colors in large SCSS files
2 participants