fix parenthesis encoding in unicode highlighting #146248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hediet
reviewed
Mar 29, 2022
| @@ -510,6 +510,10 @@ export class UnicodeHighlighterHoverParticipant implements IEditorHoverParticipa | |||
| } | |||
| } | |||
|
|
|||
| function fixedEncodeURIComponent(str: string): string { | |||
| return encodeURIComponent(str.replace(/[()]/g, escape)); | |||
There was a problem hiding this comment.
This double-escapes the string though.
hediet
reviewed
Mar 30, 2022
| @@ -496,7 +496,7 @@ export class UnicodeHighlighterHoverParticipant implements IEditorHoverParticipa | |||
|
|
|||
| const adjustSettings = nls.localize('unicodeHighlight.adjustSettings', 'Adjust settings'); | |||
| const contents: Array<IMarkdownString> = [{ | |||
| value: `${reason} [${adjustSettings}](command:${ShowExcludeOptions.ID}?${encodeURIComponent(JSON.stringify(adjustSettingsArgs))})`, | |||
| value: `${reason} [${adjustSettings}](command:${ShowExcludeOptions.ID}?${fixedEncodeURIComponent(JSON.stringify(adjustSettingsArgs))})`, | |||
There was a problem hiding this comment.
Hmm, the issue actually is that the escaping conflicts with markdown.
I think the correct fix would be to use this helper:
vscode/src/vs/base/common/htmlContent.ts
Line 78 in 30e1c0c
Sorry for only noticing now.
There was a problem hiding this comment.
Replaced with MarkdownString
|
Thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #146225