Add language-specific scope widget indicators #146343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3laoy26a
approved these changes
Mar 30, 2022
rzhao271
commented
Apr 6, 2022
| const languageToUse = this.languageService.getLanguageName(filter); | ||
| if (languageToUse) { | ||
| this.userLocalSettings.label += ` [${languageToUse}]`; | ||
| this.userRemoteSettings.label += ` [${languageToUse}]`; |
There was a problem hiding this comment.
I guess an issue here is that we might end up with Remote [hostLabel] [languageToUse] instead of Remote [hostLabel, languageToUse].
roblourens
approved these changes
Apr 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145716
This PR adds scope widget indicators in the form of [languageId] at the end of tab labels whenever there is a language filter in place. If the language filter isn't a valid language, the indicator is not shown.