Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON language status isn't "pin friendly" #146561

Closed
jrieken opened this issue Apr 1, 2022 · 2 comments
Closed

JSON language status isn't "pin friendly" #146561

jrieken opened this issue Apr 1, 2022 · 2 comments
Assignees
@jrieken @aeschli
Labels
feature-request Request for new features or functionality json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@jrieken
Copy link
Member

jrieken commented Apr 1, 2022

  • open package.json
  • pin its language status item
  • it doesn't look good...

Screenshot 2022-04-01 at 18 38 54

The item should either use (short) text and long description or we find a way to make such item unpinnable.
@aeschli
Copy link
Contributor

aeschli commented Apr 4, 2022 •
edited

It's quite tricky to find a (a) text for the pin, (b) text - detail combination that works.

Here's what I tried:
image

image

image

It would be good to also have a separate pinText

@aeschli aeschli closed this as completed in 27729fb Apr 4, 2022
@aeschli aeschli added this to the April 2022 milestone Apr 4, 2022
@aeschli aeschli added json JSON support issues feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2022
@jrieken
Copy link
Member Author

jrieken commented Apr 4, 2022

It would be good to also have a separate pinLabel

That's kinda the idea of text. It's has the same "spec" has normal status bar item. Often some codicons is used here

@alexr00 alexr00 added the verified Verification succeeded label Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@aeschli aeschli

Labels
feature-request Request for new features or functionality json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
4 participants
@jrieken @aeschli @alexr00 and others