Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to UX feedback on resolved/unresolved comments #146733

Merged
merged 2 commits into from Apr 5, 2022

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Apr 4, 2022

Part of #127473

@alexr00 alexr00 self-assigned this Apr 4, 2022
@alexr00
Copy link
Member Author

alexr00 commented Apr 4, 2022

UX feedback:

  • Yellow looks too much like a warning. Maybe we should use the peek color?
  • Bright white for resolved is too prominent.
  • Consider adding a background to the title of the comments widget.
  • Consider add an icon to the title.

What it looks like after incorporating most of the feedback:
image

I have not added an icon since the comment thread title area can be set to anything by the extension. Comments that don't set a resolved state will be unchanged.

@alexr00
Copy link
Member Author

alexr00 commented Apr 4, 2022

@laurentlb, @rebornix, and @isidorn FYI.

Once this is merged (probably tomorrow) I will adopt resolved/unresolved in the GitHub Pull Requests and Issues extension.

@laurentlb
Copy link
Contributor

Thanks a lot!

@alberto, please see the UX feedback

(cc @hermannloose)

@alexr00 alexr00 merged commit 4cbb572 into main Apr 5, 2022
@alexr00 alexr00 deleted the alexr00/issue127473 branch April 5, 2022 12:57
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants