Enable drop into editor for notebooks #146966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #146961 This makes two changes: - For drag over, make sure the cellDnd sees the event before the editor widget does (using `useCapture`). This lets us avoid showing the drop into indicator when dragging notebook cells - For drag_over and drop events, don't do anything if a cell is not being dragged. This lets us drop other things into code cells
roblourens
approved these changes
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146961
This makes two changes:
For drag over, make sure the cellDnd sees the event before the editor widget does (using
useCapture). This lets us avoid showing the drop into indicator when dragging notebook cellsFor drag_over and drop events, don't do anything if a cell is not being dragged. This lets us drop other things into code cells