Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomorrow night blue theme color JSX text color same with tag #147146

Closed
tjx666 opened this issue Apr 9, 2022 · 4 comments · Fixed by #151478
Closed

Tomorrow night blue theme color JSX text color same with tag #147146

tjx666 opened this issue Apr 9, 2022 · 4 comments · Fixed by #151478
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@tjx666
Copy link
Contributor

tjx666 commented Apr 9, 2022

Issue Type: Bug

You can see:

image

VS Code version: Code - Insiders 1.67.0-insider (Universal) (6ea335e, 2022-04-08T05:18:35.034Z)
OS version: Darwin x64 21.4.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz (8 x 1400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (1.80GB free)
Process Argv --crash-reporter-id a6dbd290-6b39-42a4-b4c8-4df35290a499
Screen Reader no
VM 0%
Extensions (64)
Extension Author (truncated) Version
better-comments aar 3.0.0
extendscript-debug Ado 2.0.0-beta3
tsl-problem-matcher amo 0.6.2
vscode-sound-player asu 0.0.3
color-info bie 0.7.0
emojisense bie 0.9.0
gif-player bie 0.0.2
github-markdown-preview bie 0.2.0
jsdoc-markdown-highlighting bie 0.0.1
markdown-checkbox bie 0.3.2
markdown-emoji bie 0.2.1
markdown-footnotes bie 0.0.7
markdown-preview-github-styles bie 1.0.1
markdown-yaml-preamble bie 0.1.0
file-browser bod 0.2.10
vscode-translation cai 2.0.4
vscode-url-title-resolver cap 1.1.1
compare-view che 0.6.0
gitignore cod 0.7.0
font-preview ctc 1.3.2
vscode-markdownlint Dav 0.47.0
vscode-eslint dba 2.2.3
githistory don 0.6.19
typescript-notebook don 2.0.6
tsimportsorter doz 7.4.17
css-flexbox-cheatsheet dzh 3.3.1
css-initial-value dzh 0.2.6
gitlens-insiders eam 2022.4.205
vscode-html-css ecm 1.11.0
vscode-npm-script eg2 0.3.24
prettier-vscode esb 9.5.0
code-runner for 0.11.7
shell-format fox 7.2.2
todo-tree Gru 0.0.215
path-autocomplete ion 1.19.1
vscode-env Iro 0.1.0
markdown-kbd jja 0.4.2
vscode-gutter-preview kis 0.30.0
call-graph Luo 1.0.0
template-string-converter meg 0.6.0
hexeditor ms- 1.9.5
js-debug-nightly ms- 2022.4.617
live-server ms- 0.2.12
vscode-js-profile-flame ms- 1.0.0
vscode-typescript-next ms- 4.7.20220408
vscode-versionlens pfl 1.0.9
vscode-css-peek pra 4.2.0
text-power-tools qcz 1.32.0
vscode-xml red 0.20.0
vscode-yaml red 1.6.0
code-spell-checker str 2.1.11
vscode-stylelint sty 1.2.2
vscodeintellicode Vis 1.2.18
vscode-icons vsc 11.10.0
adobe-extension-devtools YuT 0.0.2
open-in-external-app YuT 0.4.1
scripting-listener YuT 0.0.3
view-github-repository YuT 1.1.0
vscode-archive YuT 0.1.1
vscode-fe-helper YuT 0.2.0
ytj-snippets YuT 0.0.5
markdown-all-in-one yzh 3.4.0
material-theme zhu 3.13.20
node-modules zyr 1.1.4

(1 theme extensions excluded)

@aeschli
Copy link
Contributor

aeschli commented Apr 11, 2022

export function Foo() {
	return (
		<div>
			wwwerwer
		</div>
	);
}

You are right, that seems how the theme works.
We normally don't modify the theme that we originally imported. If you want to make a PR, you are welcome.

@aeschli aeschli added this to the Backlog Candidates milestone Apr 11, 2022
@aeschli aeschli added feature-request Request for new features or functionality themes Color theme issues labels Apr 11, 2022
@tjx666
Copy link
Contributor Author

tjx666 commented Apr 11, 2022

@aeschli I will try to make a pr this weekend.

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@aeschli aeschli modified the milestones: Backlog Candidates, June 2022 Jun 7, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 8, 2022
@aeschli aeschli added the verification-needed Verification of issue is requested label Jun 27, 2022
@alexdima alexdima added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jun 28, 2022
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
6 participants
@alexdima @aeschli @rzhao271 @tjx666 @VSCodeTriageBot and others