Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dependencies per package build for Debian #147335

Merged
merged 33 commits into from Jul 19, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 13, 2022

This PR fixes #13089.

Instead of having a hardcoded list of dependencies, we now generate the list of dependencies for the Debian package on arm64, armhf, and amd64.

TODO before merge:

  • CI tasks below pass (or, the failures are unrelated to this PR)
  • PR is reviewed
  • Package build CI is green
  • Sanity test on a Debian VM and a Ubuntu VM

@rzhao271 rzhao271 added this to the April 2022 milestone Apr 13, 2022
@rzhao271 rzhao271 self-assigned this Apr 13, 2022
@rzhao271
Copy link
Contributor Author

CI build f9c1be2209 is green

@rzhao271
Copy link
Contributor Author

Debian CI run used to generate the dependencies: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=166357&view=results

@rzhao271 rzhao271 marked this pull request as draft April 21, 2022 19:59
@rzhao271
Copy link
Contributor Author

I've converted this PR to a draft because it turns out Electron isn't supposed to have a static dependency on libgdk-pixbuf-2.0-0, especially considering that that library has slightly different names between different versions of Ubuntu. We need to firstly get Electron to dynamically link that library instead.

@ChaseKnowlden
Copy link
Contributor

Upstream PR is merged.

@ChaseKnowlden
Copy link
Contributor

Can we change this PR to a regular pull request.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Jun 20, 2022

Remaining steps:

  • Wait for Electron to release a new version with the fix
  • Update VS Code to reference that new version of Electron
  • Regenerate the dependencies and ensure libgdk-pixbuf doesn't show up in the deps list

@rzhao271 rzhao271 modified the milestones: On Deck, July 2022 Jun 27, 2022
@rzhao271 rzhao271 marked this pull request as ready for review July 5, 2022 21:15
@rzhao271
Copy link
Contributor Author

rzhao271 commented Jul 6, 2022

The package is sane and there doesn't seem to be a libgdk-pixbuf package now.

Screenshot showing the package dependencies on an Ubuntu VM

Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, couple of style changes

build/linux/rpm/dependencies-generator.ts Outdated Show resolved Hide resolved
build/linux/debian/install-sysroot.ts Outdated Show resolved Hide resolved
build/linux/debian/dep-lists.ts Outdated Show resolved Hide resolved
build/linux/debian/dep-lists.ts Outdated Show resolved Hide resolved
build/linux/debian/dep-lists.ts Outdated Show resolved Hide resolved
build/linux/debian/dependencies-generator.ts Outdated Show resolved Hide resolved
build/linux/debian/install-sysroot.ts Outdated Show resolved Hide resolved
build/linux/debian/install-sysroot.ts Outdated Show resolved Hide resolved
build/linux/debian/install-sysroot.ts Outdated Show resolved Hide resolved
build/linux/debian/install-sysroot.ts Show resolved Hide resolved
@rzhao271
Copy link
Contributor Author

rzhao271 commented Jul 19, 2022

Custom build CI passed.
I also did sanity testing yesterday and verified that the package can be installed on Ubuntu 16.04 and Debian 9 VMs.

Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rzhao271 rzhao271 merged commit 8feb40b into main Jul 19, 2022
@rzhao271 rzhao271 deleted the rzhao271/deb-dependencies branch July 19, 2022 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies in debian package
3 participants