New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate dependencies per package build for Debian #147335
Conversation
CI build f9c1be2209 is green |
Debian CI run used to generate the dependencies: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=166357&view=results |
I've converted this PR to a draft because it turns out Electron isn't supposed to have a static dependency on |
Upstream PR is merged. |
Can we change this PR to a regular pull request. |
Remaining steps:
|
f9c1be2
to
7100f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, couple of style changes
e224c02
to
de103ef
Compare
5926cf8
to
be00fd5
Compare
Custom build CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This PR fixes #13089.
Instead of having a hardcoded list of dependencies, we now generate the list of dependencies for the Debian package on arm64, armhf, and amd64.
TODO before merge: