add TabGroupChangeEvent-event which is similar to the TabChangeEvent
#147443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
reviewed
Apr 14, 2022
| @@ -271,8 +272,22 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs { | |||
|
|
|||
| $acceptEditorTabModel(tabGroups: IEditorTabGroupDto[]): void { | |||
|
|
|||
| const groupIdsBefore = new Set(this._extHostTabGroups.map(group => group.groupId)); | |||
| const groupIdsAfter = new Set(tabGroups.map(dto => dto.groupId)); | |||
| const diff = diffSets(groupIdsBefore, groupIdsAfter); | |||
There was a problem hiding this comment.
If we do patching for groups we won't have to do this in the future.
lramos15
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refinement to the tab API proposal
This is similar to the
TabChangeEventbut uses opened/closed instead of added/removed. We should align them and I think I have hereby expressed my preference ;-)