Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Selected: editor scroll bars don't respect "editorOverviewRuler.background" #147503

Closed
Z-E-D opened this issue Apr 15, 2022 · 5 comments
Closed
Labels
editor-scrollbar feature-request Request for new features or functionality

Comments

@Z-E-D
Copy link

Z-E-D commented Apr 15, 2022

When we choose Compare Selected to compare files, we get two views with three scroll bars, one for the left view, another for the right view, and immediately next to that right one we get the third scroll bar with the decorations for removed/inserted lines. These scroll bars don't respect the background color setting for editor scroll bars ("editorOverviewRuler.background"), i.e. they all have the same background color as the text in editor.

It is not so obvious since almost all themes that I tried have the background color of the editor scroll bars (overview rulers) the same as the background color of the editor itself. You could try Semantic Rainbow to see difference.

@rzhao271 rzhao271 assigned alexdima and unassigned rzhao271 Apr 15, 2022
@alexdima alexdima added feature-request Request for new features or functionality editor-scrollbar labels Apr 29, 2022
@alexdima
Copy link
Member

Related: #48153

@alexdima alexdima removed their assignment Apr 29, 2022
@Z-E-D
Copy link
Author

Z-E-D commented Apr 30, 2022

Thanks for the info. I have minimap displayed almost all the time, and because of that I didn't realize that this problem is more general, but not only when comparing two files.

So, the right title of this issue should be: "Overview rulers should respect "editorOverviewRuler.background" setting when minimap is not visible". What do you think?

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-scrollbar feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants
@alexdima @rzhao271 @Z-E-D @VSCodeTriageBot and others