Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History: delete entries that are deleted or moved on disk #14761

Closed
bpasero opened this issue Oct 31, 2016 · 6 comments
Closed

History: delete entries that are deleted or moved on disk #14761

bpasero opened this issue Oct 31, 2016 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 31, 2016

A regression from some work in October, this used to work.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Oct 31, 2016
@bpasero bpasero added this to the November 2016 milestone Oct 31, 2016
@bpasero bpasero self-assigned this Oct 31, 2016
@bpasero bpasero closed this as completed in 022c18b Nov 1, 2016
@bpasero
Copy link
Member Author

bpasero commented Dec 8, 2016

To verify, make sure that a file that you delete is removed from the recently opened in Cmd+P

@chrmarti
Copy link
Contributor

chrmarti commented Dec 8, 2016

Deleted a file in the VSCode Explorer on OSX and it was not removed from the recently opened files.

  • VSCode Version: Code - Insiders 1.8.0-insider (e087132, 2016-12-08T07:05:13.731Z)
  • OS Version: Darwin x64 15.6.0

screen shot 2016-12-08 at 10 13 32 am

@chrmarti chrmarti added the verification-found Issue verification failed label Dec 8, 2016
@chrmarti chrmarti reopened this Dec 8, 2016
@bpasero bpasero modified the milestones: November 2016, January 2017 Dec 9, 2016
@bpasero
Copy link
Member Author

bpasero commented Dec 9, 2016

@chrmarti due to a bug in hot exit, you opened the workspace folder with lowercases and this means our file watcher does not work correctly. Please run from the command line using the correct casing of the folder and try again. Then it will work.

@bpasero bpasero closed this as completed Dec 9, 2016
@bpasero bpasero removed the verification-found Issue verification failed label Dec 9, 2016
@roblourens
Copy link
Member

This now works as described if I delete the file while vscode is open. But if I close vscode, delete the file, then reopen vscode, it's still in the quick open list. Is that a different issue?

@Tyriar
Copy link
Member

Tyriar commented Dec 9, 2016

@roblourens both cases seem to work fine for me on Ubuntu?

@roblourens
Copy link
Member

There's one edge case where it doesn't work. I'm calling this verified and opening a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants