Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New comments panel: author name gets truncated #147920

Closed
laurentlb opened this issue Apr 22, 2022 · 1 comment · Fixed by #147924
Closed

New comments panel: author name gets truncated #147920

laurentlb opened this issue Apr 22, 2022 · 1 comment · Fixed by #147924
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
April 2022

Comments

@laurentlb
Copy link
Contributor

When the comment is too long to fit in the panel (which is common), the author name and the date get truncated first. Instead, we should truncate the comment:

e.g. look at the last comment in
image

Showing the author name (instead of c...) should be more important than showing a few more characters in the comment preview.

(cc @hermannloose, @alexr00)
@laurentlb laurentlb mentioned this issue Apr 22, 2022
Merged
@alexr00 alexr00 assigned alexr00 and unassigned rebornix Apr 22, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Apr 22, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 22, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Apr 27, 2022
@rchiodo rchiodo added the verified Verification succeeded label Apr 27, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Apr 27, 2022

/verified

It prefers the user name over comment now.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

Comments panel: do not truncate the author name laurentlb/vscode
6 participants
@laurentlb @rebornix @rzhao271 @rchiodo @alexr00 and others