Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close create fork message will create a fork #148437

Closed
susiwen8 opened this issue Apr 29, 2022 · 0 comments · Fixed by #148438
Closed

Close create fork message will create a fork #148437

susiwen8 opened this issue Apr 29, 2022 · 0 comments · Fixed by #148438
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@susiwen8
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.66.2 (Universal)
Commit: dfd34e8
Date: 2022-04-11T07:49:20.994Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Darwin x64 20.5.0

Steps to Reproduce:

  1. Just push a commit to a repo that user don't have permission
  2. A message modal will show to ask user if they want to create a fork repo
  3. Click close button
  4. VSCode create a fork for you
  5. But user don't want to creat a fork, that's why they close it.

Screen Shot 2022-04-29 at 11 18 18 PM

I check the code, looks like github extention only check no to return.

What I suggest

	if (answer !== yes) {
		return;
	}

If you think this were resonable, I will make a PR for it

@joaomoreno joaomoreno added the github Github extension label May 2, 2022
@joaomoreno joaomoreno assigned joaomoreno and unassigned lszomoru May 2, 2022
@joaomoreno joaomoreno added this to the May 2022 milestone May 2, 2022
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label May 2, 2022
@aeschli aeschli added the verified Verification succeeded label May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@joaomoreno @lszomoru @aeschli @susiwen8 and others