Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arguments when defining keybindings #14854

Closed
bpasero opened this issue Nov 2, 2016 · 2 comments
Closed

Support arguments when defining keybindings #14854

bpasero opened this issue Nov 2, 2016 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 2, 2016

Allow to pass arguments to commands defined in keybindings.json.

/cc @alexandrudima not sure if you have an existing item for this already?

@bpasero bpasero added feature-request Request for new features or functionality editor labels Nov 2, 2016
@bpasero bpasero added this to the November 2016 milestone Nov 2, 2016
@bpasero bpasero self-assigned this Nov 2, 2016
@bpasero bpasero closed this as completed in ec951d9 Nov 2, 2016
@bpasero
Copy link
Member Author

bpasero commented Nov 2, 2016

@alexandrudima currently I am not showing args in IntelliSense so this feature is a bit hard to learn as a new user unless you maybe check the documentation. But I also worry that it is such a corner case that it maybe would be advertised too prominently. Any ideas how to make this discoverable?

image

@alexdima
Copy link
Member

alexdima commented Nov 7, 2016

@bpasero At one point we will migrate to a single move command. ie. cursorLeft, cursorRight, etc. will all point to one command and pass in different args. It shall then become discoverable :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants