Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to only show language detection hints in text editors #148663

Merged
merged 3 commits into from May 3, 2022

Conversation

JacksonKearl
Copy link
Contributor

Fixes #148220

@JacksonKearl JacksonKearl self-assigned this May 3, 2022
@JacksonKearl JacksonKearl added the candidate Issue identified as probable candidate for fixing in the next release label May 3, 2022
@@ -113,7 +113,7 @@ const registry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Con
},
'workbench.editor.languageDetectionHints': {
type: 'string',
default: 'always',
default: 'textEditors',
tags: ['experimental'],
enum: ['always', 'notebookEditors', 'textEditors', 'never'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An object { notebookEditors: true, textEditors: true } would be more extensible to more than 2 editor types, if that would ever be relevant

@JacksonKearl JacksonKearl merged commit 3159d61 into release/1.67 May 3, 2022
@JacksonKearl JacksonKearl deleted the jackson/disable-detection-notebooks branch May 3, 2022 22:27
JacksonKearl pushed a commit that referenced this pull request May 5, 2022
* Default to only show language detection hints in text editors
Fixes #148220

* Update to object-based config

* Clarify type of untitled editor
JacksonKearl pushed a commit that referenced this pull request May 5, 2022
* Default to only show language detection hints in text editors (#148663)

* Default to only show language detection hints in text editors
Fixes #148220

* Update to object-based config

* Clarify type of untitled editor

* Limit detection to modified cells, once per second

* Re-enable in notebooks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants