Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve a11y for Settings editor markdown links #148748

Merged
merged 1 commit into from May 5, 2022
Merged

Improve a11y for Settings editor markdown links #148748

merged 1 commit into from May 5, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented May 4, 2022

This PR fixes #148747

  1. Add commas so that we don't try to interpret the two lines of rules as a single CSS rule. I'm not sure if there's a way to add a linting rule for this. It took a while to realize why the CSS wasn't being applied at all.
  2. Add a cursor: pointer line so that when users hover over a link in the Settings editor, the cursor changes to a pointer hand.

@rzhao271 rzhao271 added this to the May 2022 milestone May 4, 2022
@rzhao271 rzhao271 requested a review from roblourens May 4, 2022 23:11
@rzhao271 rzhao271 self-assigned this May 4, 2022
@rzhao271 rzhao271 removed the request for review from roblourens May 5, 2022 19:44
@sandy081 sandy081 self-requested a review May 5, 2022 19:46
@rzhao271 rzhao271 merged commit 54b6389 into main May 5, 2022
@rzhao271 rzhao271 deleted the rzhao271/se-links-a11y branch May 5, 2022 19:48
@Yellow987
Copy link

nice!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

Settings editor links don't have proper hover CSS
3 participants
@rzhao271 @Yellow987 @sandy081