add owner and comment to a telemetry event #148752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
requested changes
May 5, 2022
src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts
Outdated
Show resolved
Hide resolved
|
@lramos15 ok hopefully I got it right now? |
lramos15
requested changes
May 5, 2022
src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts
Outdated
Show resolved
Hide resolved
|
gah ok there we go |
lramos15
requested changes
May 5, 2022
There was a problem hiding this comment.
Properties should have unique comments that are not duplicates of the event. We want a living ledger that provides verbose information regarding the events and all their properties. If the comments are duplicated then they feel unnecessary and as if they add no value.
src/vs/workbench/services/languageDetection/common/languageDetectionWorkerService.ts
Outdated
Show resolved
Hide resolved
|
Ok @lramos15 how is this? |
lramos15
requested changes
May 5, 2022
|
hopefully we're good here? |
lramos15
approved these changes
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.