Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quick suggest setting settings editor friendly #148773

Merged
merged 3 commits into from May 5, 2022
Merged

Make quick suggest setting settings editor friendly #148773

merged 3 commits into from May 5, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented May 5, 2022 •
edited

  • make quickSuggestions settings just an object, no more anyOf, add editor-specific migration logic for this setting
  • mark object as "closed", add more doc

This PR fixes #148163

@jrieken jrieken self-assigned this May 5, 2022
alexdima
alexdima previously approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test here for this migration -->

vscode/src/vs/editor/test/browser/config/editorConfiguration.test.ts

Line 228 in 63076cf

suite('migrateOptions', () => {

@jrieken jrieken requested a review from alexdima May 5, 2022 07:58
@alexdima alexdima added this to the May 2022 milestone May 5, 2022
@jrieken jrieken merged commit 7d98054 into main May 5, 2022
@jrieken jrieken deleted the joh/quickSuggestConfig branch May 5, 2022 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

editor.quickSuggestions doesn't render in the Settings editor
2 participants
@jrieken @alexdima