feat: add authoritySuffix for remote labels #148841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft/vscode-remote-tunnels#250 I want to show a nicer name in the remote, but we should exclude the `categorizer+name` prefix from the authority. The "+" is a standard authority separator we use for SSH, WSL, etc.
mjbvz
approved these changes
May 5, 2022
joyceerhl
added a commit
that referenced
this pull request
May 6, 2022
joyceerhl
added a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-cli/issues/250
I want to show a nicer name in the remote, but we should exclude the
categorizer+nameprefix from the authority. The "+" is a standardauthority separator we use for SSH, WSL, etc.