Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PolicyService and use it in ConfigurationService #148943

Closed
3 tasks done
Tracked by #147756
joaomoreno opened this issue May 6, 2022 · 1 comment
Closed
3 tasks done
Tracked by #147756

Create PolicyService and use it in ConfigurationService #148943

joaomoreno opened this issue May 6, 2022 · 1 comment
Assignees
@joaomoreno @sandy081
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented May 6, 2022 •
edited by sandy081

  • Create a PolicyService @joaomoreno
  • Have ConfigurationService depend on PolicyService to be able to correctly respect setting value overwrites @sandy081
  • Create WindowsRegistryPolicySource @joaomoreno
@joaomoreno joaomoreno added feature-request Request for new features or functionality config VS Code configuration, set up issues labels May 6, 2022
@joaomoreno joaomoreno added this to the May 2022 milestone May 6, 2022
This was referenced May 6, 2022
Open
Closed
@joaomoreno joaomoreno changed the title Create PolicyService with Windows backend Create PolicyService and use it in ConfigurationService May 6, 2022
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@joaomoreno joaomoreno added verified Verification succeeded verification-needed Verification of issue is requested labels May 30, 2022
@joaomoreno
Copy link
Member Author

Verified via code review.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed feature-request Request for new features or functionality labels May 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

No branches or pull requests
2 participants
@joaomoreno @sandy081