Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting bracket #149006

Closed
tigerfeu opened this issue May 7, 2022 · 13 comments
Closed

Highlighting bracket #149006

tigerfeu opened this issue May 7, 2022 · 13 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@tigerfeu
Copy link

tigerfeu commented May 7, 2022

Issue Type: Feature Request

Hello, since the 1.67, the brackets are not matching anymore. (I dont have any visual indicator on where the brackets are (nether with the bar at the right where there was an indicator of their position, nether with the highlighting of the brackets in the code). I didnt suceed to find the parameter which could help resolve the problem. I tried to reinstall the 1.66 to check, and it is indeed caused by the 1.67.
Thank you in advance to help me with this.
Cordialy.

VS Code version: Code 1.67.0 (57fd6d0, 2022-05-04T12:06:02.889Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

@IllusionMH
Copy link
Contributor

/needsMoreInfo

Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

Please provide code language and sample that causes this problem.

@tigerfeu
Copy link
Author

tigerfeu commented May 7, 2022

Yep, same without the extension. Im actually doing a mod for stellaris (i dont know what language it is, but the files are .txt)
image
Like you can see on the image, even if my cursor is here, the bracket doesnt highlight like on the following image anymore
image

@gjsjohnmurray
Copy link
Contributor

@GHSVS-de
Copy link

GHSVS-de commented May 7, 2022

I can confirm the issue.

The weird thing ist: When I set "editor.bracketPairColorization.enabled" to false coloring and matching comes back like in previous version.

But haven't tested yet with disabled extensions.

@tigerfeu
Copy link
Author

tigerfeu commented May 7, 2022

Well, i just saw something else, maybe related, i dont know since im beginning on Visual Studio Code.
First, thank you to both of you for your time, but i already came across this, doesnt change anything.
Second, it seems depending the location of the folder im working on, i get the highlight and color back.
For information, the folder that didnt have the highlight and color is on my desk, the other folder which is working fine is in a subfolder of "my documents" (but i have color and highlight only with the extension on) Maybe you got some info about that? Is that normal? Are they normally no colour and highlight in Virtual Studio Code?
Cordialy

@GHSVS-de
Copy link

GHSVS-de commented May 8, 2022

I don't know if it helps here anyhow. Maybe it's a completely different issue. My tests:

A)

  • As long as deprecated extension "bracket-pair-colorizer-2" is enabled and "editor.bracketPairColorization.enabled" is false I see bracket colors and matching also in mixed files.

*Example 1: .html with Go code:
image

*Example 2: .md with HuGo code:
image

B)

  • Start migration of "bracket-pair-colorizer-2" to core (or how it was called),
  • set "editor.bracketPairColorization.enabled" to true
  • Restart VS Code.
  • => No bracket colors and matching in above mixed files.
  • I have to additionally use in my user settings.json to get back the old behavior:
"editor.bracketPairColorization.enabled": true,
"editor.language.colorizedBracketPairs": [
 ["[", "]"],
 ["(", ")"],
 ["{", "}"],
 ["<", "</"],
 ["<", "/>"],
]

So, at least, the migration changes the "loved" behavior and is not really B\C.

@tigerfeu
Copy link
Author

tigerfeu commented May 8, 2022

Yep, perfect, i got color for bracket and visual indicator both by highlight and in the right bar, thank you.

@tigerfeu tigerfeu closed this as completed May 8, 2022
@hediet hediet added this to the May 2022 milestone May 9, 2022
@hediet hediet reopened this May 9, 2022
@FlyingOnion
Copy link

I can confirm the issue.

The weird thing ist: When I set "editor.bracketPairColorization.enabled" to false coloring and matching comes back like in previous version.

But haven't tested yet with disabled extensions.

Helps a lot. I really hate this feature. It ruins a good morning.

@georgjz
Copy link

georgjz commented May 18, 2022

For those who want bracket matching/highlighting without colors:

    "editor.matchBrackets": "always",
    "editor.bracketPairColorization.enabled": false,
    "editor.language.colorizedBracketPairs": [["(", ")"]],

@hediet hediet modified the milestones: May 2022, June 2022 Jun 2, 2022
@avicularian
Copy link

The recent update ruined my old setup.

Now, Bracket Pair Colorizer 2 does not work, no matter what combination of settings I employ.

It's necessary for me to use this extension, as the new "native" VSCode colorization caps out at 6 colours.

As I use highly nested languages like Lisp (Clojure) and Dart with Flutter, it's ruined my coding experience as 6 colours is far too few to be able to follow where you are in the code structure. I tend to use 20.

Once you've tried writing in Clojure or Flutter with 20-level-deep colorization, as opposed to 6, it's impossible to go back. It makes things much, much more manageable.

So, because of this "update", I shall have to downgrade. I'm eagerly awaiting a fix (which, incidentally, would be very, very simply for the VSCode team to achieve).

@hediet
Copy link
Member

hediet commented Jun 30, 2022

Now, Bracket Pair Colorizer 2 does not work, no matter what combination of settings I employ.

You have to explicitly disable native bracket pair colorization.

@hediet hediet removed this from the June 2022 milestone Jul 1, 2022
@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

10 participants