Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select the hit condition UI? #14927

Closed
actboy168 opened this issue Nov 3, 2016 · 17 comments
Closed

Can't select the hit condition UI? #14927

actboy168 opened this issue Nov 3, 2016 · 17 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@actboy168
Copy link

  • VSCode Version: Code 1.7.1 (02611b4, 2016-11-03T13:53:14.822Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
lua-debug actboy168 0.0.11
status-bar-tasks GuardRex 0.1.0
cpptools ms-vscode 0.9.2
color-highlight naumovs 1.2.1

gif

Steps to Reproduce:

@rebornix rebornix added info-needed Issue requires more information from poster and removed info-needed Issue requires more information from poster labels Nov 3, 2016
@octref
Copy link
Contributor

octref commented Nov 3, 2016

@actboy168
Don't use =2. Use 2 instead.

But I think we should still do input validation.

@isidorn
Copy link
Contributor

isidorn commented Nov 3, 2016

Input validation -> dup of #14364

@isidorn isidorn closed this as completed Nov 3, 2016
@actboy168
Copy link
Author

'2' is the same.
gif
The UI tell me, '2' is a condition and it is not a hit condition.

@actboy168
Copy link
Author

@octref
Copy link
Contributor

octref commented Nov 4, 2016

@actboy168
Sorry my bad. =2 is valid. Haven't used much of this feature 😛

Can you try setting conditional breakpoints before you start debugging?

@isidorn This seems to happen if you set conditional breakpoints after you've started debugging.

@octref octref reopened this Nov 4, 2016
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Nov 4, 2016
@actboy168
Copy link
Author

gif2

@octref
Copy link
Contributor

octref commented Nov 4, 2016

Are you using node2 in your launch.json? Can you change that to node and see if it works?

I'm also able to repro with this setup:

image

@octref
Copy link
Contributor

octref commented Nov 4, 2016

/CC @weinand

@actboy168
Copy link
Author

Yes, node2. And the same to node.

@isidorn isidorn assigned weinand and unassigned isidorn and waderyan Nov 4, 2016
@weinand
Copy link
Contributor

weinand commented Nov 4, 2016

@roblourens does node2 support hit count conditions?

@roblourens
Copy link
Member

No, the UI doesn't get disabled in that case?

@weinand
Copy link
Contributor

weinand commented Nov 4, 2016

@roblourens breakpoint configuration is global and independent from a debug adapter. So the UI for configuring breakpoint conditions and hitcount expressions is always available.

@isidorn we need to find a UI that communicates to the user upon session start that a configured breakpoint condition and/or hitcount expression is actually ignored by a debug adapter.

@roblourens
Copy link
Member

Ah right. They could go gray when you start debugging with a message, "Hit condition breakpoints aren't supported by XYZ". Also I filed an issue on myself to implement these. microsoft/vscode-chrome-debug-core#125

@weinand
Copy link
Contributor

weinand commented Nov 4, 2016

The breakpoint will probably work but the expressions are ignored. So we could show the red disk but remove the '=' from it.

@actboy168
Copy link
Author

Which debugger adapter supports hit condition breakpoints?
I try to support hit condition breakpoints in my debugger adapter, but I found the vscode however will only give me a condition breakpoint not a hit condition breakpoint.

@weinand
Copy link
Contributor

weinand commented Nov 14, 2016

@actboy168 as far as I know only Node Debug (debug type = "node") supports hit conditions at the moment. But this can change at any time. Please check the release notes of the debug extensions you are interested in.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues and removed bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2016
@weinand
Copy link
Contributor

weinand commented Nov 14, 2016

This works for me:

2016-11-14_13-19-27

@weinand weinand closed this as completed Nov 14, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

7 participants