-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't select the hit condition UI? #14927
Comments
@actboy168 But I think we should still do input validation. |
Input validation -> dup of #14364 |
http://code.visualstudio.com/docs/editor/debugging#_hit-count-condition |
@actboy168 Can you try setting conditional breakpoints before you start debugging?
|
/CC @weinand |
Yes, node2. And the same to node. |
@roblourens does node2 support hit count conditions? |
No, the UI doesn't get disabled in that case? |
@roblourens breakpoint configuration is global and independent from a debug adapter. So the UI for configuring breakpoint conditions and hitcount expressions is always available. @isidorn we need to find a UI that communicates to the user upon session start that a configured breakpoint condition and/or hitcount expression is actually ignored by a debug adapter. |
Ah right. They could go gray when you start debugging with a message, "Hit condition breakpoints aren't supported by XYZ". Also I filed an issue on myself to implement these. microsoft/vscode-chrome-debug-core#125 |
The breakpoint will probably work but the expressions are ignored. So we could show the red disk but remove the '=' from it. |
Which debugger adapter supports hit condition breakpoints? |
@actboy168 as far as I know only Node Debug (debug type = "node") supports hit conditions at the moment. But this can change at any time. Please check the release notes of the debug extensions you are interested in. |
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: