Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt setTimeout0() which doesn't suffer from the 4ms artificial delay that browsers set when the nesting level is > 5. #149723

Merged
merged 1 commit into from May 17, 2022
Merged

Adopt setTimeout0() which doesn't suffer from the 4ms artificial delay that browsers set when the nesting level is > 5. #149723

merged 1 commit into from May 17, 2022

Conversation

alexdima
Copy link
Member

No description provided.

@alexdima
Adopt setTimeout0() which doesn't suffer from the 4ms artificial de…
7cc927b 
…lay that browsers set when the nesting level is > 5.
@alexdima alexdima enabled auto-merge (squash) May 17, 2022 15:11
@alexdima alexdima self-assigned this May 17, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone May 17, 2022
@alexdima
Copy link
Member Author

alexdima commented May 17, 2022 •
edited

@Tyriar Is this a real problem on main?

[valid-layers-check] [build/lib/layersChecker.ts]: Reference to symbol 'window' from 'lib.dom.d.ts' violates layer '**/vs/**/common/**' (/mnt/vss/_work/1/s/src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts (233,29)

@alexdima alexdima merged commit 2c97c80 into main May 17, 2022
@alexdima alexdima deleted the alexd/reliable-earthworm branch May 17, 2022 15:52
alexdima added a commit that referenced this pull request May 17, 2022
@alexdima
Revert "Adopt setTimeout0() which doesn't suffer from the 4ms artif…
6237076 
…icial delay that browsers set when the nesting level is > 5. (#149723)"

This reverts commit 2c97c80.
alexdima added a commit that referenced this pull request May 17, 2022
@alexdima
Revert "Adopt setTimeout0() which doesn't suffer from the 4ms artif…
7ca85c3 
…icial delay that browsers set when the nesting level is > 5. (#149723)" (#149742)

This reverts commit 2c97c80.
wannieman98 pushed a commit to wannieman98/vscode that referenced this pull request May 17, 2022
@alexdima @wannieman98
Adopt setTimeout0() which doesn't suffer from the 4ms artificial de…
55050bf 
…lay that browsers set when the nesting level is > 5. (microsoft#149723)
wannieman98 pushed a commit to wannieman98/vscode that referenced this pull request May 17, 2022
@alexdima @wannieman98
Revert "Adopt setTimeout0() which doesn't suffer from the 4ms artif…
ab99c94 
…icial delay that browsers set when the nesting level is > 5. (microsoft#149723)" (microsoft#149742)

This reverts commit 2c97c80.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexdima @connor4312 @VSCodeTriageBot