Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: regarding to refreshHandler #150010

Open
matepek opened this issue May 20, 2022 · 5 comments
Open

Testing: regarding to refreshHandler #150010

matepek opened this issue May 20, 2022 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality testing Built-in testing support
Milestone

Comments

@matepek
Copy link

matepek commented May 20, 2022

Hello,

I'm coming from this issue.

So my user's issue is that when I'm rediscovering automatically (based on file system watcher events or config change) the tests I can not tell the user that rediscovery is happening.
I'm aware that I can flip the is_busy on a TestItem but the problem is that if there are new test files under discovery there is no TestItem for them.

So what we are looking for is a "global" is_busy which would turn the refresh button to stop button and would show that progress bar thingy.

cc: @connor4312 , @stefanhaller

@connor4312
Copy link
Member

connor4312 commented May 20, 2022

You can use our existing progress APIs for show progress, at least, though this doesn't influence the "stop" button

vscode.window.showProgress({ ...options, location: { viewId: 'workbench.view.extension.test' } }, doDiscover);

@connor4312 connor4312 added feature-request Request for new features or functionality testing Built-in testing support labels May 20, 2022
@connor4312 connor4312 added this to the Backlog milestone May 20, 2022
@matepek
Copy link
Author

matepek commented May 21, 2022

Let me try that ^^

@matepek
Copy link
Author

matepek commented May 21, 2022

It doesn't seem that the vscode.window has showProgress function.. 🤔

@matepek
Copy link
Author

matepek commented May 21, 2022

Maybe this:

vscode.window.withProgress({ location: { viewId: 'workbench.view.extension.test' } }, () => ...);

?

@matepek
Copy link
Author

matepek commented May 21, 2022

With this the progress bar works but the reload/cancel button isn't affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality testing Built-in testing support
Projects
None yet
Development

No branches or pull requests

2 participants