Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update electron@17.4.6 #150727

Merged
merged 1 commit into from May 30, 2022
Merged

chore: update electron@17.4.6 #150727

merged 1 commit into from May 30, 2022

Conversation

deepak1556
Copy link
Contributor

Addresses the following from #150167 (comment)

* args/execArgv shapes are different compared to nodejs
* on('spawn') / on('exit') are never fired

@deepak1556 deepak1556 added this to the May 2022 milestone May 30, 2022
@deepak1556 deepak1556 self-assigned this May 30, 2022
@deepak1556 deepak1556 requested a review from alexdima May 30, 2022 15:28
@deepak1556 deepak1556 enabled auto-merge (squash) May 30, 2022 15:28
@deepak1556 deepak1556 merged commit 1a39a4e into main May 30, 2022
@deepak1556 deepak1556 deleted the robo/update_electron branch May 30, 2022 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @alexdima