Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three way merge editor dependencies #150766

Closed
bpasero opened this issue May 31, 2022 · 1 comment
Closed

Three way merge editor dependencies #150766

bpasero opened this issue May 31, 2022 · 1 comment
Assignees
@hediet
Labels
debt Code quality issues merge-editor
Milestone
July 2022

Comments

@bpasero
Copy link
Member

bpasero commented May 31, 2022

@hediet I noticed a strange dependency to vs/workbench/contrib/audioCues, shouldn't that be a base thing to reuse and avoid tangles like that?

I also think we typically not call something util.ts to avoid a kitchen sink of sorts.

Originally posted by @bpasero in #150709 (review)
@bpasero bpasero added debt Code quality issues merge-editor labels May 31, 2022
@hediet hediet modified the milestones: May 2022, June 2022 May 31, 2022
@hediet hediet modified the milestones: June 2022, July 2022 Jun 29, 2022
@hediet
Copy link
Member

hediet commented Jul 27, 2022 •
edited

The observables now live in common, thus there is no more weird dependency.

@hediet hediet closed this as completed Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
debt Code quality issues merge-editor
Projects
None yet
Milestone
July 2022
Development

No branches or pull requests
2 participants
@bpasero @hediet