WCO: black border under buttons

[bpasero]

I see a black border under the WCO only in light themes:

[rzhao271]

I'm unable to reproduce the issue on the latest Insiders on Windows 10. Are you still able to?

[bpasero]

Weird, now seeing this again in my VM:

But I still cannot really reproduce on my new Surface Laptop...

[deepak1556]

Seems like an issue only when hw acceleration is disabled electron/electron#31025

I could repro on windows hardware when running with --disable-gpu

[bpasero]

Nice!

[bpasero]

Actually I think I was also tricked by the fact that WCO was not enabled by default on Windows: 2857051

[Roundlay]

Is this solely related to hardware acceleration?

I'm seeing the same black line under the window buttons in Code with GPU acceleration enabled, as well as in other Electron apps, namely Signal.

In Code's case, I see the black line under the window buttons in two situations:

• When both window.commandCenter and window.experimental.windowControlsOverlay.enabled are set to true. In this case, the black line seems to disappear when Code is maximised or fullscreened.
• When window.commandCenter is set to false but window.experimental.windowControlsOverlay.enabled is set to true. In this case, the black line seems to appear when Code is maximised.

The black line occasionally shows up only after extended use,

GPU acceleration was enabled when testing these parameters, but I am using 125% display scaling, which has been reported as a trigger by others.

Here's the same issue in Signal:

[rzhao271]

The upstream issue has been fixed by electron/electron#35312.
VS Code has taken in this change, so actually, this issue has been resolved.

Verification steps:

1. On Windows, enable WCO (enable the window.experimental.windowControlsOverlay.enabled setting), and set the screen display scale to 125%
2. Use a light theme for VS Code
3. Verify that under the minimize/restore/maximize buttons, there's no black border. Maximize and restore the window and verify there's no black border under those buttons in both cases.