Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the drop down cancel the hover but open editors and other random actions don't? #150887

Closed
TylerLeonhardt-alt opened this issue May 31, 2022 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@TylerLeonhardt-alt
Copy link

Testing #150557

Recording 2022-05-31 at 10 26 52

I have alt held down this whole time.

This is @TylerLeonhardt's alt account on Linux

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2022

I believe this is fixed with #151185

@Tyriar Tyriar closed this as completed Jun 3, 2022
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 3, 2022
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug workbench-hover Hover issues in the workbench and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jun 3, 2022
@TylerLeonhardt TylerLeonhardt added this to the May 2022 milestone Jun 3, 2022
@TylerLeonhardt
Copy link
Member

@Tyriar added to the milestone so it gets tested for endgame since the original issue duplicated to doesn't have the same steps

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2022

@TylerLeonhardt I think clicking on the dropdown is expected to hide the hover as you show since it's a native dialog popping up. If anything clicking elsewhere out of the hover while alt is held is undefined behavior. I didn't aim to explicitly hide the hover in those cases but if it does I don't think that matters and is worth handling, the user should just let go of alt if they want it hidden.

@TylerLeonhardt TylerLeonhardt removed bug Issue identified by VS Code Team member as probable bug workbench-hover Hover issues in the workbench labels Jun 3, 2022
@TylerLeonhardt TylerLeonhardt removed this from the May 2022 milestone Jun 3, 2022
@TylerLeonhardt TylerLeonhardt added the *as-designed Described behavior is as designed label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

5 participants