Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments view should have ability to filter by resolved/unresolved #150958

Closed
ant0nsc opened this issue Jun 1, 2022 · 2 comments · Fixed by #158264
Closed

Comments view should have ability to filter by resolved/unresolved #150958

ant0nsc opened this issue Jun 1, 2022 · 2 comments · Fixed by #158264
Assignees
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@ant0nsc
Copy link

ant0nsc commented Jun 1, 2022

Issue Type: Feature Request

In the Comments window, I see tons of comments on my PR, but I find it difficult to focus on the ones that are still open. There is a minor visual difference (blue/grey icon), but I would much rather have an ability to choose what is displayed (all/resolved/unresolved)

Extension version: 0.42.0
VS Code version: Code 1.67.2 (c3511e6, 2022-05-17T18:15:52.058Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2

@alexr00 alexr00 self-assigned this Jun 1, 2022
@alexr00 alexr00 transferred this issue from microsoft/vscode-pull-request-github Jun 1, 2022
@alexr00 alexr00 added feature-request Request for new features or functionality comments Comments Provider/Widget/Panel issues labels Jun 1, 2022
@alexr00 alexr00 added this to the June 2022 milestone Jun 1, 2022
@joaomoreno joaomoreno changed the title "Comments" window should have ability to filter by resolved/unresolved Comments view should have ability to filter by resolved/unresolved Jun 10, 2022
@hermannloose
Copy link
Contributor

Related: #142081 has some mocks for distinguishing unresolved comments better in the comments panel through icons and color. I believe at the moment, only the comment views in the code editor are colored differently?

#127476 might be interesting to look at for designing the implementation, as it asked for more generic "tagging" of comment threads by the extensions that create them. I know that right now we only have resolved vs unresolved in the API, but it might make sense to keep the filtering logic slightly more generic in anticipation of more facets to filter by in the future (e.g. "only comment threads I am involved in, regardless of resolvedness" etc.).

@alexr00 alexr00 modified the milestones: June 2022, July 2022 Jun 24, 2022
@alexr00
Copy link
Member

alexr00 commented Jul 22, 2022

This is what the Problems view does (I clicked on the filter icon):

image

Something like this will allow for #127476 too. If we add a tag like property to comment threads later, then we can read incorporate that into the list and maybe even add a filter input box too.

For now though, I will add something similar to the filter menu in problems with "Show Resolved" and "Show Unresolved" options.

@alexr00 alexr00 modified the milestones: July 2022, August 2022 Jul 26, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 16, 2022
@alexr00 alexr00 mentioned this issue Aug 22, 2022
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@hermannloose @ant0nsc @alexr00 @VSCodeTriageBot and others