Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sync label formatters across machines #150987

Merged
merged 1 commit into from Jun 2, 2022
Merged

Don't sync label formatters across machines #150987

merged 1 commit into from Jun 2, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 1, 2022

Fixes #150970

I didn't test this as it's hard to test without it being in product but it seems like this should fix. Since the scope is different I believe the old contents will not be used do there's no migration needed to fix (can confirm after update).

@Tyriar Tyriar added this to the May 2022 milestone Jun 1, 2022
@Tyriar Tyriar requested a review from bpasero June 1, 2022 16:24
@Tyriar Tyriar self-assigned this Jun 1, 2022
@bpasero bpasero requested review from connor4312 and removed request for bpasero June 2, 2022 06:04
@Tyriar
Copy link
Member Author

Tyriar commented Jun 2, 2022

@connor4312 should be in on Monday which will make the release 👌

@Tyriar Tyriar mentioned this pull request Jun 2, 2022
@sbatten sbatten self-requested a review June 2, 2022 20:58
@sbatten
Copy link
Member

sbatten commented Jun 2, 2022

Connor added the formatter caching to help with recent history formatting. That data isn't sync'd across machines either so this change looks good to me.

@Tyriar Tyriar merged commit 5665196 into main Jun 2, 2022
@Tyriar Tyriar deleted the tyriar/150970 branch June 2, 2022 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy path commands using wrong path separator on macOS
2 participants