Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental grammar mistake to .d.ts #150991

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

lramos15
Copy link
Member

@lramos15 lramos15 commented Jun 1, 2022

Looks like @jrieken brought in an accidental grammar change to the tabs API in the .d.ts. This just returns the word to its previous status

@lramos15 lramos15 self-assigned this Jun 1, 2022
@lramos15 lramos15 added this to the May 2022 milestone Jun 1, 2022
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using whose for an object always felt wrong so I consulted an expert first 😆 https://www.merriam-webster.com/words-at-play/whose-used-for-inanimate-objects

@lramos15
Copy link
Member Author

lramos15 commented Jun 1, 2022

Using whose for an object always felt wrong so I consulted an expert first 😆 https://www.merriam-webster.com/words-at-play/whose-used-for-inanimate-objects

Yeah it just seems to flow better in this sentence. Although I think it was originally which and then was suggested to change to whose which is how it was accidentally turned back back to which.

@lramos15 lramos15 enabled auto-merge (squash) June 1, 2022 17:05
@lramos15 lramos15 merged commit 84241b2 into main Jun 1, 2022
@lramos15 lramos15 deleted the lramos15/devoted-minnow branch June 1, 2022 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants