Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GitHub and GitHub Repositories extension scopes #151044

Closed
TylerLeonhardt opened this issue Jun 1, 2022 · 0 comments · Fixed by #151045
Closed

Align GitHub and GitHub Repositories extension scopes #151044

TylerLeonhardt opened this issue Jun 1, 2022 · 0 comments · Fixed by #151045
Assignees
Labels
github Github extension insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Because of the alignment we did here:
microsoft/vscode-pull-request-github#3377

GitHub Repos & GHPRI now have the same scopes... unfortunately, the built-in GitHub extension did not receive the same alignment and as a result, you get 2 sign-ins back to back when using GitHub Repos on Desktop:

  1. to get the repo picker to load (GH extension)
  2. to load the remote workspace (GHR extension)

We should have the GitHub extension request: ['repo', 'workflow', 'user:email', 'read:user'] so that all of our extensions here are aligned.

We need to do this alignment because GitHub doesn't have a mechanism yet for "token downscoping".

@TylerLeonhardt TylerLeonhardt added the github Github extension label Jun 1, 2022
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 1, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone Jun 1, 2022
@joaomoreno joaomoreno removed their assignment Jun 2, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github Github extension insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants