Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation not working in settings JSON #151107

Closed
aeschli opened this issue Jun 2, 2022 · 2 comments · Fixed by #151202
Closed

Validation not working in settings JSON #151107

aeschli opened this issue Jun 2, 2022 · 2 comments · Fixed by #151202
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders json JSON support issues verified Verification succeeded
Milestone
May 2022

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 2, 2022

Version: 1.68.0-insider
Commit: 15253f1
Date: 2022-06-02T05:17:01.962Z

  • open the Settings JSON editor
  • add some unnecessary commas
  • no problems reported in the problems view.
  • open the JSON Language Server log. Observe that there are no diagnostic requests. Other requests are sent and completed, so the language server is running.
@aeschli aeschli added this to the May 2022 milestone Jun 2, 2022
@aeschli aeschli added json JSON support issues bug Issue identified by VS Code Team member as probable bug labels Jun 2, 2022
@chrmarti
Copy link
Contributor

chrmarti commented Jun 3, 2022

Maybe unrelated: I was expecting "trailing comma" warnings in devcontainer.json (we recently changed the schema to not accept them), but they only started showing after I flushed the schema cache (using the UI command) and reloaded the window (I can't completely rule out that a window reload alone would have helped).

@aeschli aeschli mentioned this issue Jun 3, 2022
Merged
@aeschli
Copy link
Contributor Author

aeschli commented Jun 3, 2022

@chrmarti I checked that with the fix the trailing commas are reported

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 3, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 3, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders json JSON support issues verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Validation not working in settings JSON microsoft/vscode
5 participants
@dbaeumer @aeschli @chrmarti @joyceerhl @VSCodeTriageBot