Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure PS1/2 aren't re-wrapped in bash shell integration #151232

Merged
merged 1 commit into from Jun 3, 2022
Merged

Make sure PS1/2 aren't re-wrapped in bash shell integration #151232

merged 1 commit into from Jun 3, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 3, 2022

Part of #150478

Tested on:

  • mac PS1
  • mac PROMPT_COMMAND
  • mac starship
  • bash PS1

Feels pretty safe to merge in considering the above seemed to work fine, the bug it's fixing of multiple decorations was pretty nasty too.

@Tyriar Tyriar added this to the May 2022 milestone Jun 3, 2022
@Tyriar Tyriar requested a review from meganrogge June 3, 2022 16:45
@Tyriar Tyriar self-assigned this Jun 3, 2022
@Tyriar Tyriar enabled auto-merge June 3, 2022 16:51
@Tyriar Tyriar merged commit 36bedff into main Jun 3, 2022
@Tyriar Tyriar deleted the tyriar/150478 branch June 3, 2022 16:53
@Tyriar Tyriar mentioned this pull request Jun 3, 2022
Closed
@meganrogge meganrogge mentioned this pull request Jun 3, 2022
Closed
@Tyriar Tyriar mentioned this pull request Jun 13, 2022
Closed
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tyriar @meganrogge