Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching breakpoint condition should preserve the condition in breakpoint widget #15151

Closed
isidorn opened this issue Nov 8, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 8, 2016

Originaly from @rkeithhill

For me, the only issue that exists here is that the dropdown UI does not save the current value when switching between Expression and Hit Count. I know the watermark text says to hit press Enter but I think a fair number or folks will type an Expression, hit the drop down to set the Hit Count, then they press Enter. In this scenario only the Hit Count is accepted. The condition expression is not.

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 8, 2016
@isidorn isidorn added this to the November 2016 milestone Nov 8, 2016
@isidorn isidorn self-assigned this Nov 8, 2016
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Nov 10, 2016

To verify: enter both condition and hit condition for a breakpoint and make sure both get applied.

fyi @rkeithhill this is now fixed

@chrmarti chrmarti added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants